Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase report frequency of ad viewability changes #873

Closed
cramforce opened this issue Nov 7, 2015 · 0 comments
Closed

Increase report frequency of ad viewability changes #873

cramforce opened this issue Nov 7, 2015 · 0 comments
Assignees

Comments

@cramforce
Copy link
Member

Research standard and then follow it within technical capability.

This refines #872

@cramforce cramforce self-assigned this Nov 7, 2015
cramforce added a commit to cramforce/amphtml that referenced this issue Dec 18, 2015
emit viewport change events on scroll.

- The scroll event now always fires in vsync and always measures
scrollTop.
- The viewport change event now happens at the latest 3 frames after
scrolling ended.
- Increased speed at which we send change event. Needed due to resolution at slow speed, but I also feel the value is better.

Changes ad intersection to fire "on scroll". Fixes ampproject#873

Fixes a bug where only the first viewability provider in an ad would get an initial viewability change record. Fixes ampproject#1126
msukmanowsky pushed a commit to Parsely/amphtml that referenced this issue Jan 21, 2016
emit viewport change events on scroll.

- The scroll event now always fires in vsync and always measures
scrollTop.
- The viewport change event now happens at the latest 3 frames after
scrolling ended.
- Increased speed at which we send change event. Needed due to resolution at slow speed, but I also feel the value is better.

Changes ad intersection to fire "on scroll". Fixes ampproject#873

Fixes a bug where only the first viewability provider in an ad would get an initial viewability change record. Fixes ampproject#1126
This was referenced Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant