Fix broken system social share in Webviews and Opera UA detection #11556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
approved these changes
Oct 4, 2017
|
Why not just use a try catch? I dislike using UA detection if possible. |
|
It can't be used here. The API pops out the system share UI if no exception is thrown. |
|
I thought it was the |
|
@jridgewell discussed here: https://bugs.chromium.org/p/chromium/issues/detail?id=765923 (comment #6 and #7). yes UPDATE: |
cramforce
reviewed
Oct 5, 2017
| systemShareSupported_() { | ||
| // Chrome exports navigator.share in WebView but does not implement it. | ||
| // See https://bugs.chromium.org/p/chromium/issues/detail?id=765923 | ||
| const isChromeWebview = this.viewer_.isWebviewEmbedded() && |
There was a problem hiding this comment.
Should we also at least add a special case for the Facebook UA string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11473
Chrome does not implement System Share in WebViews (See https://bugs.chromium.org/p/chromium/issues/detail?id=765923 ) but exposes
navigator.shareAPI (throws exception on call) so we now we have to use some UA detection to see if system share is supported or not.Chrome 60+ also started sending
OPR(opera) as part of user agent string, this PR also fixes that.