Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch placeholder for amp-video to poster #6

Closed
cramforce opened this issue Sep 3, 2015 · 3 comments
Closed

Switch placeholder for amp-video to poster #6

cramforce opened this issue Sep 3, 2015 · 3 comments
Assignees
@dvoytenko

Comments

@cramforce
Copy link
Member

Or decide the opposite.

From Taylor:
Poster would certainly be simpler/more platform aligned. The initial reasoning was to allow for more flexibility - if the author wanted to include anything more complex than an image, like a fancy splash screen with a custom play overlay that changed on hover, for example.

But certainly in favor of narrowing scope in the preview for this one and any others.
@dvoytenko
Copy link
Contributor

I actually really like the [placeholder] elements. They already work mostly everywhere and a very standard way to do placeholders for AMP. WDYT?

@dvoytenko
Copy link
Contributor

One of the improvements of [placeholder] over "poster" is that [placeholder] gives us options to customize the quality of the poster image, just as with any other image.

@cramforce
Copy link
Member Author

I'm cool with sticking with the placeholder thing. We might still want to
support poster.

On Mon, Sep 7, 2015 at 1:00 PM Dima Voytenko notifications@github.com
wrote:

One of the improvements of [placeholder] over "poster" is that
[placeholder] gives us options to customize the quality of the poster
image, just as with any other image.

—
Reply to this email directly or view it on GitHub
#6 (comment).

@aghassemi aghassemi mentioned this issue Oct 4, 2017
Merged
alabiaga pushed a commit that referenced this issue Feb 28, 2019
@PhilWinchester @alabiaga
✨Create new extension - AMP-smartlinks (#20967)
6a78bcb 
* creating new amp-smartlinks extension

* BAM-2584 AMP-Smartlinks (#3)

* adding example page and amp-smartlinks to bundles.config

* creating amp-smartlinks scaffolding

* BAM-2584 adding hardcoded POC implementation of amp-smartlinks

* adding new constants file and linkmate file/class

* adding linkmate call and association working with link-rewrite service

* add amp config call and update workflow to use those values

* setup initial amp-smartlinks and linkmate workflow

* adding new config variables for link attribute and selector

* add tests for amp-smartlinks

* add test for linkmate.js

* add more thorough anchorList check in runSmartlinks

* adding code comments, new constants structure and better options validation

* update amp-smartlinks to have helpful information

* updating global vars and cleaning up main files

* clean up tests and add more explicit type assertions

* clean up jsdoc tags

* BAM-2585 Whitelist import, fix type errors, and replace user.assert with userAssert (#4)

* BAM-2585 whitelist navigation import and fix type errors

* replace user.assert with userAssert

* BAM-2585 fix validator and type check (#5)

* more validator fixes (#6)

* BAM-2585 Fix validator, copyright, and whitespace (#7)

* alphabetize validator, fix whitespace, and add valid tag

* update year in copyright statement

* BAM-2585 move `link-rewriter` to import statements and updating types (#8)

* BAM-2585 remove link-rewriter and switch to importing from skimlinks extension

* clean up promise chain and more descriptive API comments

* update xhr to pull from ampdoc.win and add types to constants.js

* fix type in buildPageImpressionPayload_

* update validator with new empty value check (#9)

* update validator for exclusive-links

* switch page-impression API request to customEventReporter (#11)

* BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_impression request (#12)

* fix jsdoc for linkmate params and make runLinkmate more readable (#13)

* add try/catch on amp_config fetch and updated constants.js

* remove bad type in constants.js and add check for existing shop-links (#14)

* add check for auction_id in mapLinks and add jsdoc for SMARTLINKS_REWRITER_ID

* fix type notation in constants.js and linkmate-options.js

* fix indentation in example file

* add note to README describing link-rewriter priority queue behavior (#15)

* add exception to compile.js for amp-skimlinks

* update validator to use empty value as indicator linkmate param

* fix validator and linkmate-options to use new config style (#16)

* updating tests for linkmate-options.js

* remove redundant userAssert in linkmate-options

* update tests to reflect config changes

* update tests to send accurate config params

* update readme to refelct config changes and more accurate function names in linkmate-options
noranazmy pushed a commit to noranazmy/amphtml that referenced this issue Mar 22, 2019
@PhilWinchester
✨Create new extension - AMP-smartlinks (ampproject#20967)
c50a74a 
* creating new amp-smartlinks extension

* BAM-2584 AMP-Smartlinks (#3)

* adding example page and amp-smartlinks to bundles.config

* creating amp-smartlinks scaffolding

* BAM-2584 adding hardcoded POC implementation of amp-smartlinks

* adding new constants file and linkmate file/class

* adding linkmate call and association working with link-rewrite service

* add amp config call and update workflow to use those values

* setup initial amp-smartlinks and linkmate workflow

* adding new config variables for link attribute and selector

* add tests for amp-smartlinks

* add test for linkmate.js

* add more thorough anchorList check in runSmartlinks

* adding code comments, new constants structure and better options validation

* update amp-smartlinks to have helpful information

* updating global vars and cleaning up main files

* clean up tests and add more explicit type assertions

* clean up jsdoc tags

* BAM-2585 Whitelist import, fix type errors, and replace user.assert with userAssert (ampproject#4)

* BAM-2585 whitelist navigation import and fix type errors

* replace user.assert with userAssert

* BAM-2585 fix validator and type check (ampproject#5)

* more validator fixes (ampproject#6)

* BAM-2585 Fix validator, copyright, and whitespace (ampproject#7)

* alphabetize validator, fix whitespace, and add valid tag

* update year in copyright statement

* BAM-2585 move `link-rewriter` to import statements and updating types (ampproject#8)

* BAM-2585 remove link-rewriter and switch to importing from skimlinks extension

* clean up promise chain and more descriptive API comments

* update xhr to pull from ampdoc.win and add types to constants.js

* fix type in buildPageImpressionPayload_

* update validator with new empty value check (ampproject#9)

* update validator for exclusive-links

* switch page-impression API request to customEventReporter (ampproject#11)

* BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_impression request (ampproject#12)

* fix jsdoc for linkmate params and make runLinkmate more readable (ampproject#13)

* add try/catch on amp_config fetch and updated constants.js

* remove bad type in constants.js and add check for existing shop-links (ampproject#14)

* add check for auction_id in mapLinks and add jsdoc for SMARTLINKS_REWRITER_ID

* fix type notation in constants.js and linkmate-options.js

* fix indentation in example file

* add note to README describing link-rewriter priority queue behavior (ampproject#15)

* add exception to compile.js for amp-skimlinks

* update validator to use empty value as indicator linkmate param

* fix validator and linkmate-options to use new config style (ampproject#16)

* updating tests for linkmate-options.js

* remove redundant userAssert in linkmate-options

* update tests to reflect config changes

* update tests to send accurate config params

* update readme to refelct config changes and more accurate function names in linkmate-options
bramanudom pushed a commit to bramanudom/amphtml that referenced this issue Mar 22, 2019
@PhilWinchester @bramanudom
✨Create new extension - AMP-smartlinks (ampproject#20967)
2959313 
* creating new amp-smartlinks extension

* BAM-2584 AMP-Smartlinks (ampproject#3)

* adding example page and amp-smartlinks to bundles.config

* creating amp-smartlinks scaffolding

* BAM-2584 adding hardcoded POC implementation of amp-smartlinks

* adding new constants file and linkmate file/class

* adding linkmate call and association working with link-rewrite service

* add amp config call and update workflow to use those values

* setup initial amp-smartlinks and linkmate workflow

* adding new config variables for link attribute and selector

* add tests for amp-smartlinks

* add test for linkmate.js

* add more thorough anchorList check in runSmartlinks

* adding code comments, new constants structure and better options validation

* update amp-smartlinks to have helpful information

* updating global vars and cleaning up main files

* clean up tests and add more explicit type assertions

* clean up jsdoc tags

* BAM-2585 Whitelist import, fix type errors, and replace user.assert with userAssert (ampproject#4)

* BAM-2585 whitelist navigation import and fix type errors

* replace user.assert with userAssert

* BAM-2585 fix validator and type check (ampproject#5)

* more validator fixes (ampproject#6)

* BAM-2585 Fix validator, copyright, and whitespace (ampproject#7)

* alphabetize validator, fix whitespace, and add valid tag

* update year in copyright statement

* BAM-2585 move `link-rewriter` to import statements and updating types (ampproject#8)

* BAM-2585 remove link-rewriter and switch to importing from skimlinks extension

* clean up promise chain and more descriptive API comments

* update xhr to pull from ampdoc.win and add types to constants.js

* fix type in buildPageImpressionPayload_

* update validator with new empty value check (ampproject#9)

* update validator for exclusive-links

* switch page-impression API request to customEventReporter (ampproject#11)

* BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_impression request (ampproject#12)

* fix jsdoc for linkmate params and make runLinkmate more readable (ampproject#13)

* add try/catch on amp_config fetch and updated constants.js

* remove bad type in constants.js and add check for existing shop-links (ampproject#14)

* add check for auction_id in mapLinks and add jsdoc for SMARTLINKS_REWRITER_ID

* fix type notation in constants.js and linkmate-options.js

* fix indentation in example file

* add note to README describing link-rewriter priority queue behavior (ampproject#15)

* add exception to compile.js for amp-skimlinks

* update validator to use empty value as indicator linkmate param

* fix validator and linkmate-options to use new config style (ampproject#16)

* updating tests for linkmate-options.js

* remove redundant userAssert in linkmate-options

* update tests to reflect config changes

* update tests to send accurate config params

* update readme to refelct config changes and more accurate function names in linkmate-options
@abhiz10 abhiz10 mentioned this issue Nov 17, 2021
Open
erwinmombay pushed a commit that referenced this issue Jul 31, 2023
@youssef-attia
♻️🐛 [Trusted Types] Make AmpWorker Trusted Types compatible (#39211)
54c0400 
* ♻️🐛 [Trusted Types] Make AmpWorker Trusted Types compatible (#6)

* fix regex to match subdomains properly

* fixing regex

* fixing hostname regex

* typo

* lint changes

* lint fix

* conditional fix

* testing string conversion before passing

* more permissive for testing

* update test regex with more urls

* fixing hostname

* adding one more url to test allowlist

* removing restrictions on testing due to dynamic url

* mjs file extensions

* replace slice with endsWith for readability
eszponder referenced this issue in krzysztofequativ/amphtml Apr 22, 2024
@youssef-attia @eszponder
♻️🐛 [Trusted Types] Make AmpWorker Trusted Types compatible (ampproje…
0b692c0 
…ct#39211)

* ♻️🐛 [Trusted Types] Make AmpWorker Trusted Types compatible (#6)

* fix regex to match subdomains properly

* fixing regex

* fixing hostname regex

* typo

* lint changes

* lint fix

* conditional fix

* testing string conversion before passing

* more permissive for testing

* update test regex with more urls

* fixing hostname

* adding one more url to test allowlist

* removing restrictions on testing due to dynamic url

* mjs file extensions

* replace slice with endsWith for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvoytenko dvoytenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cramforce @dvoytenko