Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off red highlighting for error syntax (e.g. amp-form) #286

Merged
merged 2 commits into from
Jan 11, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2017

Red highlighting is distracting in code syntax (for example, using ellipses or the lightning bolt are considered errors).

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@pbakaus pbakaus merged commit caaeedf into master Jan 11, 2017
@pbakaus pbakaus deleted the fix-error-css branch January 11, 2017 16:50
@ghost ghost mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants