Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variables translatable + minor css #350

Merged
1 commit merged into from
Mar 9, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2017

  1. Corrected elements in markdown and yaml files to make certain elements (mostly titles) pulled out for translation (add @).
  2. Fix CSS so that red highlighting doesn't display for syntax highlighting (like we had before in PR 286)

@ghost ghost requested a review from leeee March 9, 2017 14:21
Copy link
Contributor

@leeee leeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@ghost ghost merged commit bbcbc66 into master Mar 9, 2017
@ghost ghost deleted the docs-fix-translatables branch March 9, 2017 15:28
@ghost
Copy link
Author

ghost commented Mar 9, 2017

@leeee - thanks! Should I extract translations as well? Actually when I did (locally), I got a lot more in the messages.pot file (a lot of translated text). I'm wondering if the translated yaml files were needed (for example, overview@ar.yaml), that is, the translation text could be addressed in the language's po file; or at least remove the @ in the translated files so the text isn't extracted.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant