Skip to content

For #170: Added tests to Images.import #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

paulodamaso
Copy link
Contributor

For #170:

  • Added test to Images.import
  • Left todo for continue to implement Images methods

@0crat 0crat added the scope label Dec 27, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

Job #249 is now in scope, role is REV

@coveralls
Copy link

coveralls commented Dec 27, 2018

Pull Request Test Coverage Report for Build 439

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.97%

Totals Coverage Status
Change from base Build 431: 0.0%
Covered Lines: 576
Relevant Lines: 670

💛 - Coveralls

@amihaiemil amihaiemil self-requested a review December 29, 2018 16:14
@0crat
Copy link
Collaborator

0crat commented Jan 2, 2019

This pull request #249 is assigned to @bkuzmic/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jan 2, 2019

Job gh:amihaiemil/docker-java-api#249 already assigned to @bkuzmic, can't assign to @bkuzmic

@amihaiemil amihaiemil removed their request for review January 2, 2019 11:24
Copy link
Contributor

@bkuzmic bkuzmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso Thanks for the PR. Looks good!

@bkuzmic
Copy link
Contributor

bkuzmic commented Jan 2, 2019

@rultor merge it.

@rultor
Copy link
Collaborator

rultor commented Jan 2, 2019

@rultor merge it.

@bkuzmic Thanks for your request. @amihaiemil Please confirm this.

@amihaiemil
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 3, 2019

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jan 3, 2019

@rultor merge

@amihaiemil @paulodamaso Oops, I failed. You can see the full log here (spent 3min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 13088
+ echo '1.68.1 24dc2a841'
1.68.1 24dc2a841
+ date
Thu Jan  3 13:07:17 CET 2019
+ uptime
 13:07:17 up 19 days,  3:37,  0 users,  load average: 6.77, 6.94, 6.75
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
+ pull_title='For #170: Added tests to Images.import'
+ author=amihaiemil
+ directory=
+ head=git@github.com:amihaiemil/docker-java-api.git
+ pull_id=249
+ fork=git@github.com:paulodamaso/docker-java-api.git
+ fork_branch=170
+ squash=false
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=head=git@github.com:amihaiemil/docker-java-api.git' '--env=pull_id=249' '--env=fork=git@github.com:paulodamaso/docker-java-api.git' '--env=fork_branch=170' '--env=head_branch=master' '--env=pull_title=For #170: Added tests to Images.import' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:amihaiemil/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=249'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:paulodamaso/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=170'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=For #170: Added tests to Images.import'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle'\'' '\'';'\'' )')
+ scripts=('export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=249'\''' ';' 'export '\''fork=git@github.com:paulodamaso/docker-java-api.git'\''' ';' 'export '\''fork_branch=170'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #170: Added tests to Images.import'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';')
+ container=amihaiemil_docker-java-api_249
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:amihaiemil/docker-java-api.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=249'\''' ';' 'export '\''fork=git@github.com:paulodamaso/docker-java-api.git'\''' ';' 'export '\''fork_branch=170'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #170: Added tests to Images.import'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpgkeys: key 9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly

@amihaiemil
Copy link
Owner

@rultor merge

@amihaiemil amihaiemil merged commit 91e4e75 into amihaiemil:master Jan 3, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 3, 2019

@rultor merge

@amihaiemil @paulodamaso The pull request is closed already, so I can't merge it

@rultor
Copy link
Collaborator

rultor commented Jan 3, 2019

@rultor merge

@amihaiemil I'm sorry, I don't understand you :( Check this page and try again please

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Job was finished in 26 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the scope label Jan 3, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

The job #249 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Order was finished: +20 point(s) just awarded to @bkuzmic/z

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants