SENTRY-514224 Prevent array to string conversion error #2
Conversation
| if (is_array($value) && 1 === count($value)) { | ||
| $value = reset($value); | ||
| } | ||
|
|
There was a problem hiding this comment.
can you please shortly explain why is it needed and why is it php7 related?
Is (string)$array works differently in php7?
How it supposed to work in $value is an array but with more them 1 element?
There was a problem hiding this comment.
It is not really php7 related, did popup before as well. The Choice validator casts choice values to strings before checking if they exist in $choices array, but the values can be arrays as well (here a sfWidgetFormSelectRadio widget). To prevent the warning/notification the value array should be replaced by its only item
There was a problem hiding this comment.
I think it is a misuse of the validator - because it has other clean function for the case when multiple choice is enabled
protected function doClean($value)
{
$choices = $this->getChoices();
if ($this->getOption('multiple'))
{
$value = $this->cleanMultiple($value, $choices);
}
else
{
if (!self::inChoices($value, $choices))
{
throw new sfValidatorError($this, 'invalid', array('value' => $value));
}
}
return $value;
}
So somewhere "multiple" widget is used with choice validator where "multiple" option is not enabled. We rather fix that one, than making this change.
ValueError: fread(): Argument #2 ($length) must be greater than 0 TypeError: count(): Argument #1 ($value) must be of type Countable|array Foo Given Use Symfony Polyfill symfony/polyfill@d330c00 TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given Do not use Symfony pollyfill, is_array is enought
no QA needed