Fix doClean() of sfValidatorBoolean #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use strict comparison in `in_array()` and add boolean and usual integer values to 'true_values' and 'false_values' options
wutsch0
requested review from
bbt-amboss,
obukhov,
pen-amboss,
tlt-miamed and
ysi-amboss
tlt-miamed
approved these changes
Mar 19, 2020
bbt-amboss
approved these changes
Mar 19, 2020
MiguelAlcaino
pushed a commit
that referenced
this pull request
Aug 18, 2023
MiguelAlcaino
pushed a commit
that referenced
this pull request
Aug 18, 2023
ValueError: fread(): Argument #2 ($length) must be greater than 0 TypeError: count(): Argument #1 ($value) must be of type Countable|array Foo Given Use Symfony Polyfill symfony/polyfill@d330c00 TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given Do not use Symfony pollyfill, is_array is enought
MiguelAlcaino
pushed a commit
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to loose comparision in
in_array()unexpected results occure, i.e.:$value = 0results in cleaning the value totrueinstead offalsebecause
in_array(0, ['true', 't', 'yes', 'y', 'on', '1']) = truesince0 == 'true'=>0 === (int)'true'=>0 === 0To fix that enable type strict comparison in
in_array()and add boolean values as well as usual integer values to 'true_values' and 'false_values' options