test and release note for connamara#473

connamara#473
amandengue · Jul 15, 2019 · 4d00986 · 4d00986
1 parent e15757a
commit 4d00986
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -29,6 +29,7 @@ What's New
 * (patch) #509 - Consistent sessionID argument name in IApplication (eugbaranov)
 * (patch) #296 - make FieldMap.GetField obsolete; favor .GetString instead (staffanu)
 * (patch) #478 - eliminate unnecessary string/byte flip-flop (gbirchmeier)
+* (patch) #473 - correct ordering of fields in message trailer (Ieshaj/gbirchmeier)
 
 ### v1.8.0:
 * (patch) #402 - Multithreading fix to please NUnit 2.6.3 and above (arkadiuszwojcik)

diff --git a/UnitTests/MessageTests.cs b/UnitTests/MessageTests.cs
@@ -930,5 +930,19 @@ public void SetFieldsTest()
             Assert.AreEqual(true, message.IsSetField(Tags.AllocAccountType));
             Assert.AreEqual(AllocAccountType.HOUSE_TRADER, message.GetInt(Tags.AllocAccountType));
         }
+
+        [Test]
+        public void ChecksumIsLastFieldOfTrailer()
+        {
+            // issue 473
+            QuickFix.FIX42.News msg = new QuickFix.FIX42.News(new Headline("foobar"));
+            msg.LinesOfText = new LinesOfText(0);
+
+            msg.Trailer.SetField(new Signature("woot"));
+            msg.Trailer.SetField(new SignatureLength(4));
+
+            string foo = msg.ToString().Replace(Message.SOH, "|");
+            StringAssert.EndsWith("|10=099|", foo);
+        }
     }
 }