Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ordering in message trailer #473

Closed
wants to merge 1 commit into from
Closed

Conversation

Ieshaj
Copy link
Contributor

@Ieshaj Ieshaj commented Feb 23, 2018

I was using this package to connect to an RMS that required a signature to be filled. When I filled both Signature and SignatureLength, the message trailer fields became out of order, the checksum was not being sent as the last field of the message, as it should be.

@gbirchmeier
Copy link
Member

Great catch. I'm pulling this into my own branch so I can add a test.

@gbirchmeier
Copy link
Member

Merged into #538

gbirchmeier added a commit that referenced this pull request Jul 15, 2019
correct ordering of fields in message trailer - #473
gbirchmeier added a commit that referenced this pull request Jul 15, 2019
hlibman-connamara pushed a commit to hlibman-connamara/quickfixn that referenced this pull request Dec 6, 2024
hlibman-connamara pushed a commit to hlibman-connamara/quickfixn that referenced this pull request Dec 6, 2024
correct ordering of fields in message trailer - connamara#473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants