Skip to content

Fix invalid components #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix invalid components #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d99e2a1
fix cooldown component
SleepSpace9 Jun 4, 2023
6a0de8a
Fix DisplayNameComponent
SleepSpace9 Jun 4, 2023
fb4140b
Fix max_stack_size getting ignored from config
SleepSpace9 Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/alvin0319/CustomItemLoader/item/properties/CustomItemProperties.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ private function parseData(array $data) : void{
$itemPropertiesComponent->addComponent("hand_equipped", $trueTag);
}
if(isset($data["max_stack_size"])){
$itemPropertiesComponent->addComponent("max_stack_size", new IntTag($data["max_stack_size"]));
$this->max_stack_size = (int)$data["max_stack_size"];
$itemPropertiesComponent->addComponent("max_stack_size", new IntTag($this->max_stack_size));
}
// if(isset($data["mining_speed"])){
// $this->setMiningSpeed($data["mining_speed"]);
Expand Down
2 changes: 1 addition & 1 deletion src/alvin0319/CustomItemLoader/item/properties/component/CooldownComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ public function processComponent(CompoundTag $rootNBT) : void{
throw new InvalidNBTStateException("Component tree is not built");
}
$cooldownTag->setString("category", "attack"); // TODO: Find out this
$cooldownTag->setFloat("value", $this->cooldown / 20); // maybe in tick
$cooldownTag->setFloat("duration", $this->cooldown / 20); // maybe in tick
}
}
12 changes: 4 additions & 8 deletions src/alvin0319/CustomItemLoader/item/properties/component/DisplayNameComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,18 @@ final class DisplayNameComponent extends Component{
public function __construct(private readonly string $displayName){ }

public function getName() : string{
return "texture";
return "display_name";
}

public function buildComponent(CompoundTag $rootNBT) : void{
$componentTag = $rootNBT->getCompoundTag(Component::TAG_COMPONENTS);
if($componentTag === null){
throw new InvalidNBTStateException("Component tree is not built");
}
$componentTag->setTag(self::TAG_DISPLAY_NAME, CompoundTag::create());
$rootNBT->setTag(self::TAG_DISPLAY_NAME, CompoundTag::create());
}

public function processComponent(CompoundTag $rootNBT) : void{
$displayNameTag = $rootNBT->getCompoundTag(Component::TAG_COMPONENTS)?->getCompoundTag(self::TAG_DISPLAY_NAME);
$displayNameTag = $rootNBT->getCompoundTag(self::TAG_DISPLAY_NAME);
if($displayNameTag === null){
throw new InvalidNBTStateException("Component tree is not built");
}
$displayNameTag->setString("value", $this->displayName);
}
}
}