Skip to content

Conversation

@SleepSpace9
Copy link
Contributor

No description provided.

@alvin0319
Copy link
Owner

What is the source of this?

@SleepSpace9
Copy link
Contributor Author

It was set like this (and working) before you merged your api breaking PR.
I noticed it was wrong when I tried to join the server while I had custom items in the config that use a cooldown. The client told me Failed to validate components for item ... due to the following: - Failed to validate component 'minecraft:cooldown'

@SleepSpace9
Copy link
Contributor Author

SleepSpace9 commented Jun 4, 2023

I just saw the DisplayNameComponent needs also a fix.

EDIT: And there's even more to fix.

The display_name compound tag is not nested in components, it's in the root.
@alvin0319 alvin0319 changed the title fix cooldown component Fix invalid components Jun 5, 2023
@alvin0319
Copy link
Owner

Thanks, Are there any leftover mistakes?

@SleepSpace9
Copy link
Contributor Author

There's still more, e.g. some global variables in the CustomItemProperties class are not set when the corresponding component is applied, and other variables are only set local and never update the global variables, so the getter methods will always return the default values.

Unfortunately I didn't have time to continue working on that, sorry...

@alvin0319
Copy link
Owner

There's still more, e.g. some global variables in the CustomItemProperties class are not set when the corresponding component is applied, and other variables are only set local and never update the global variables, so the getter methods will always return the default values.

Unfortunately I didn't have time to continue working on that, sorry...

well, I don't care about those getters, since I was about to remove them. what I meant was are there any leftover component-related mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants