Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo errors #326

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Fixed typo errors #326

merged 7 commits into from
Dec 22, 2023

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Dec 22, 2023

This commit fixes some general typo errors.

  • Fixed method invocation typo in DeployStep. It is a regression introduced in Added no regression tests for provenance #150.
  • Improved format in terminal output when color feature is enabled.
  • Showed warning message about maxConcurrentJobs only when necessary.
  • Removed Slurm references in SSH description schema.
  • Removed unnecessary parameter in _get_timeout method in CWLBaseCommand class.
  • Typos in schema descritions and helper messages.

@LanderOtto
Copy link
Collaborator Author

About the point "Improved format in terminal output when color feature is enabled.", below i attach the comparison of the old and new format

  • Previous format: Screenshot 2023-12-22 01-22-41
  • New format: Sceenshot 2023-12-22 01-24-29

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b4d9b8d) 67.09% compared to head (12cf966) 67.10%.
Report is 1 commits behind head on master.

Files Patch % Lines
streamflow/deployment/connector/kubernetes.py 0.00% 1 Missing ⚠️
streamflow/deployment/connector/queue_manager.py 0.00% 1 Missing ⚠️
streamflow/log_handler.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   67.09%   67.10%   +0.01%     
==========================================
  Files          82       82              
  Lines       10254    10255       +1     
  Branches     2424     2425       +1     
==========================================
+ Hits         6880     6882       +2     
  Misses       2950     2950              
+ Partials      424      423       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit dec9150 into master Dec 22, 2023
31 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the refactor/method-names branch December 22, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants