Added no regression tests for provenance #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 65.41% 64.61% -0.81%
==========================================
Files 81 81
Lines 9771 9974 +203
Branches 2312 2344 +32
==========================================
+ Hits 6392 6445 +53
- Misses 2979 3126 +147
- Partials 400 403 +3
☔ View full report in Codecov by Sentry. |
LanderOtto
force-pushed
the
test/provenance
branch
from
d96b548
to
53cb74d
Compare
GlassOfWhiskey
requested changes
Jun 1, 2023
streamflow/workflow/combinator.py
Outdated
| @@ -17,6 +17,7 @@ def _add_to_list( | |||
| token_values: MutableMapping[str, MutableMapping[str, MutableSequence[Any]]], | |||
| port_name: str, | |||
| depth: int = 0, | |||
| is_cartesian: bool = False, | |||
There was a problem hiding this comment.
What does this is_cartesian parameter do?
LanderOtto
force-pushed
the
test/provenance
branch
from
5066a5c
to
a548f3a
Compare
LanderOtto
force-pushed
the
test/provenance
branch
from
ec23530
to
332f85a
Compare
GlassOfWhiskey
requested changes
Jun 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some no regression tests on the provenance module