Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Config persistence #289

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Fixed Config persistence #289

merged 4 commits into from
Nov 30, 2023

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Nov 23, 2023

This commit fixes the ScheduleStep persistence, particularly the BindingFilter object.
The filters attribute in BindingFilter was not being saved correctly in the database.
A new class extends the Config, called FilterConfig, and a new table was added to the database.

The extention of PersistableEntity was moved from Config to its superclasses only where needed, i.e. DeploymentConfig and FilterConfig.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (980a511) 65.89% compared to head (b973338) 66.00%.

Files Patch % Lines
streamflow/persistence/sqlite.py 73.33% 4 Missing ⚠️
streamflow/deployment/utils.py 25.00% 3 Missing ⚠️
streamflow/config/config.py 60.00% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   65.89%   66.00%   +0.10%     
==========================================
  Files          82       82              
  Lines       10151    10180      +29     
  Branches     2398     2409      +11     
==========================================
+ Hits         6689     6719      +30     
- Misses       3029     3030       +1     
+ Partials      433      431       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit 52f8882 into master Nov 30, 2023
31 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/config-persistence branch November 30, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants