minor fix

alpha-unito · Nov 27, 2023 · ef99aa4 · ef99aa4
1 parent b973338
commit ef99aa4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/streamflow/deployment/utils.py b/streamflow/deployment/utils.py
@@ -71,7 +71,6 @@ def get_binding_config(
         return BindingConfig(
             targets=targets,
             filters=[
-                # tmp solution
                 FilterConfig(name=c.name, type=c.type, config=c.config)
                 for c in config.get("filters")
             ],

diff --git a/tests/test_persistence.py b/tests/test_persistence.py
@@ -145,11 +145,7 @@ async def test_schedule_step(context: StreamFlowContext):
                 workdir=utils.random_name(),
             ),
         ],
-        filters=[
-            FilterConfig(
-                config={"hello": "world"}, name=utils.random_name(), type="shuffle"
-            )
-        ],
+        filters=[FilterConfig(config={}, name=utils.random_name(), type="shuffle")],
     )
     connector_ports = {
         target.deployment.name: workflow.create_port(ConnectorPort)
@@ -337,9 +333,7 @@ async def test_iteration_termination_token(context: StreamFlowContext):
 @pytest.mark.asyncio
 async def test_filter_config(context: StreamFlowContext):
     """Test saving and loading filter configuration from database"""
-    config = FilterConfig(
-        config={"hello": "world"}, name=utils.random_name(), type="shuffle"
-    )
+    config = FilterConfig(config={}, name=utils.random_name(), type="shuffle")
     await save_load_and_test(config, context)