Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support no_std for alloy-genesis/alloy-serde #320

Merged
merged 12 commits into from
Mar 21, 2024
Merged

feat: support no_std for alloy-genesis/alloy-serde #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cdb7c4d
feat: support no_std for alloy-genesis/alloy-serde
yjhmelody Mar 15, 2024
1add125
remove unused file
yjhmelody Mar 15, 2024
355a1db
fmt
yjhmelody Mar 15, 2024
26eceb4
fix for tests
yjhmelody Mar 15, 2024
3a3c3ac
adjust a little
yjhmelody Mar 15, 2024
cdc117f
clippy warnings
yjhmelody Mar 15, 2024
68f4297
clippy warnings
yjhmelody Mar 15, 2024
7bb2a8f
use feature gate
yjhmelody Mar 15, 2024
5a5479a
fix feature gate
yjhmelody Mar 15, 2024
cbc398d
fmt
yjhmelody Mar 15, 2024
397c245
Update Cargo.toml
mattsse Mar 15, 2024
41c7ebf
Update README.md
prestwich Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/serde/src/json_u256.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
//! Json U256 serde helpers.

#[allow(unused_imports)]
Copy link
Contributor Author

@yjhmelody yjhmelody Mar 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the clippy warnings are not correct, for no_std must import String/ToString.
If not imports them, cargo test -p alloy-serde --no-default-features will fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can feature gate these imports instead:

see also

https://github.com/alloy-rs/alloy/blob/main/crates/eips/src/eip2930.rs#L7-L8

use alloc::{fmt, format, string::String};
use core::str::FromStr;

Expand Down
1 change: 1 addition & 0 deletions crates/serde/src/num.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
//! Numeric serde helpers.

#[allow(unused_imports)]
use alloc::{str::FromStr, string::ToString};

use alloy_primitives::{U256, U64};
Expand Down
1 change: 1 addition & 0 deletions crates/serde/src/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#[allow(unused_imports)]
use alloc::{
collections::BTreeMap,
fmt::Write,
Expand Down
Loading