feat: support no_std for alloy-genesis/alloy-serde #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjhmelody
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
yjhmelody
commented
Mar 15, 2024
crates/serde/src/json_u256.rs
Outdated
| @@ -1,5 +1,6 @@ | |||
| //! Json U256 serde helpers. | |||
|
|
|||
| #[allow(unused_imports)] | |||
There was a problem hiding this comment.
Seems the clippy warnings are not correct, for no_std must import String/ToString.
If not imports them, cargo test -p alloy-serde --no-default-features will fail.
There was a problem hiding this comment.
you can feature gate these imports instead:
see also
https://github.com/alloy-rs/alloy/blob/main/crates/eips/src/eip2930.rs#L7-L8
mattsse
requested changes
Mar 15, 2024
| @@ -226,7 +230,7 @@ pub struct GenesisAccount { | |||
| skip_serializing_if = "Option::is_none", | |||
| deserialize_with = "deserialize_storage_map" | |||
| )] | |||
| pub storage: Option<HashMap<B256, B256>>, | |||
| pub storage: Option<BTreeMap<B256, B256>>, | |||
There was a problem hiding this comment.
I actually prefer the BtreeMap change here so serialize/deserialize is consistent
crates/serde/src/json_u256.rs
Outdated
| @@ -1,5 +1,6 @@ | |||
| //! Json U256 serde helpers. | |||
|
|
|||
| #[allow(unused_imports)] | |||
There was a problem hiding this comment.
you can feature gate these imports instead:
see also
https://github.com/alloy-rs/alloy/blob/main/crates/eips/src/eip2930.rs#L7-L8
crates/serde/src/json_u256.rs
Outdated
Comment on lines
182
to
183
| #[allow(unused_imports)] | ||
| use alloc::{vec, vec::Vec}; |
There was a problem hiding this comment.
onbjerg
approved these changes
Mar 19, 2024
Co-authored-by: Oliver Nordbjerg <onbjerg@users.noreply.github.com>
malik672
added a commit
to malik672/alloy
that referenced
this pull request
Mar 21, 2024
feat: support no_std for alloy-genesis/alloy-serde (alloy-rs#320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist