Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUES #8635] fix a NPE when call the shutdown method #8636

Merged
merged 2 commits into from
Jun 28, 2022
Merged

[ISSUES #8635] fix a NPE when call the shutdown method #8636

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ba1c7
[ISSUES #8635] fix a NPE when call the shutdown method
onewe Jun 27, 2022
46164cb
[ISSUES #8635] remove init judgment
onewe Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions naming/src/main/java/com/alibaba/nacos/naming/consistency/persistent/raft/RaftCore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,15 +464,24 @@ public void onDelete(String datumKey, RaftPeer source) throws Exception {
@Override
public void shutdown() throws NacosException {
this.stopWork = true;
if (!initialized) {
onewe marked this conversation as resolved.
Show resolved Hide resolved
return;
}
this.raftStore.shutdown();
this.peers.shutdown();
Loggers.RAFT.warn("start to close old raft protocol!!!");
Loggers.RAFT.warn("stop old raft protocol task for notifier");
NotifyCenter.deregisterSubscriber(notifier);
Loggers.RAFT.warn("stop old raft protocol task for master task");
masterTask.cancel(true);
Loggers.RAFT.warn("stop old raft protocol task for heartbeat task");
heartbeatTask.cancel(true);
if (masterTask != null) {
Loggers.RAFT.warn("stop old raft protocol task for master task");
masterTask.cancel(true);
}

if (heartbeatTask != null) {
Loggers.RAFT.warn("stop old raft protocol task for heartbeat task");
heartbeatTask.cancel(true);
}

Loggers.RAFT.warn("clean old cache datum for old raft");
datums.clear();
}
Expand Down