Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES #8635] fix a NPE when call the shutdown method #8636

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Jun 27, 2022

Close #8635

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #8636 (46164cb) into develop (f3d134d) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8636      +/-   ##
=============================================
- Coverage      41.58%   41.57%   -0.02%     
+ Complexity      4459     4458       -1     
=============================================
  Files            882      882              
  Lines          32124    32127       +3     
  Branches        3719     3721       +2     
=============================================
- Hits           13359    13357       -2     
- Misses         17416    17417       +1     
- Partials        1349     1353       +4     
Impacted Files Coverage Δ
...s/naming/consistency/persistent/raft/RaftCore.java 9.88% <66.66%> (-0.04%) ⬇️
.../naming/push/v1/NamingSubscriberServiceV1Impl.java 66.66% <0.00%> (-15.88%) ⬇️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 69.04% <0.00%> (-14.29%) ⬇️
...ent/manager/impl/EphemeralIpPortClientManager.java 68.00% <0.00%> (-2.00%) ⬇️
...alibaba/nacos/core/remote/control/TpsRecorder.java 74.32% <0.00%> (-1.36%) ⬇️
...va/com/alibaba/nacos/naming/utils/ServiceUtil.java 50.40% <0.00%> (-0.81%) ⬇️
...a/com/alibaba/nacos/naming/push/v1/PushClient.java 46.93% <0.00%> (ø)
...te/rpc/handler/SubscribeServiceRequestHandler.java 100.00% <0.00%> (ø)
.../core/v2/event/publisher/NamingEventPublisher.java 76.25% <0.00%> (+1.25%) ⬆️
.../com/alibaba/nacos/common/notify/NotifyCenter.java 53.84% <0.00%> (+7.69%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53d50c...46164cb. Read the comment docs.

Oliverwqcwrw
Oliverwqcwrw previously approved these changes Jun 28, 2022
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Jun 28, 2022
@KomachiSion KomachiSion added this to the 2.1.1 milestone Jun 28, 2022
@KomachiSion KomachiSion merged commit 56ee220 into alibaba:develop Jun 28, 2022
@onewe onewe deleted the issues/8635 branch June 28, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] RaftCore occur a NPE when call the shutdown method
4 participants