-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8515] Optimize some code in InetUtils #8522
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #8522 +/- ##
=============================================
+ Coverage 41.24% 41.42% +0.17%
- Complexity 4396 4450 +54
=============================================
Files 876 882 +6
Lines 31868 32120 +252
Branches 3708 3719 +11
=============================================
+ Hits 13145 13306 +161
- Misses 17406 17472 +66
- Partials 1317 1342 +25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不能移除,这个应该是有用的,修改本机ip,或者修改本机是否使用域名时有用。
@KomachiSion 我看代码,这个没有任何调度器来调度.
这里创建了一个 runnable 后面直接就run了
这个时间也没用到 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那是否应该添加个调度器把它调度起来,而不是删掉他?
401e07f
to
7c1b6a4
Compare
这玩意儿的单元测试太难写了 |
- reformat by nacos-style
Close #8515
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.