Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimize] Some code can be optimized in InetUtils #8515

Closed
onewe opened this issue Jun 6, 2022 · 0 comments · Fixed by #8522
Closed

[Optimize] Some code can be optimized in InetUtils #8515

onewe opened this issue Jun 6, 2022 · 0 comments · Fixed by #8522

Comments

@onewe
Copy link
Collaborator

onewe commented Jun 6, 2022

nacos.core.inet.auto-refresh property is deprecated, isn't it? so, I think about the ipAutoRefresh can be removed and unregistered IPChangeEvent .

看了一下代码,发现nacos.core.inet.auto-refresh属性已经被弃用,所以我觉得ipAutoRefresh这个可以被移除,并且IPChangeEvent事件也可以不用注册

image
@onewe onewe mentioned this issue Jun 6, 2022
Merged
5 tasks
onewe added a commit to onewe/nacos that referenced this issue Jun 13, 2022
@onewe
[ISSUE alibaba#8515] auto refresh ip address
baa35f8 
Close alibaba#8515
onewe added a commit to onewe/nacos that referenced this issue Jun 13, 2022
@onewe
[ISSUE alibaba#8515] add the unit test
2c9cc7c 
Close alibaba#8515
onewe added a commit to onewe/nacos that referenced this issue Jun 13, 2022
@onewe
[ISSUE alibaba#8515] clean system variable after unit test done
fdf35d3 
Close alibaba#8515
onewe added a commit to onewe/nacos that referenced this issue Jun 13, 2022
@onewe
[ISSUE alibaba#8515] add tearDown method for the unit test
fdd3cc3 
- reformat by nacos-style
onewe added a commit to onewe/nacos that referenced this issue Jun 17, 2022
@onewe
[ISSUE alibaba#8515] fix ci error
717a084
onewe added a commit to onewe/nacos that referenced this issue Jun 17, 2022
@onewe
[ISSUE alibaba#8515] fix ci error
590b883
onewe added a commit to onewe/nacos that referenced this issue Jun 17, 2022
@onewe
[ISSUE alibaba#8515] fix ci error
3203119
KomachiSion pushed a commit that referenced this issue Jun 20, 2022
@onewe
[ISSUE #8515] Optimize some code in InetUtils (#8522)
cbda95d 
* [ISSUE #8515] auto refresh ip address

Close #8515

* [ISSUE #8515] add the unit test

Close #8515

* [ISSUE #8515] clean system variable after unit test done

Close #8515

* [ISSUE #8515] add tearDown method for the unit test

- reformat by nacos-style

* [ISSUE #8515] fix ci error

* [ISSUE #8515] fix ci error

* [ISSUE #8515] fix ci error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8515] Optimize some code in InetUtils onewe/nacos
1 participant
@onewe