[ISSUE #3046] Unify the treatment of constant variables and reduce the usage of "magic numbers" #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/http/NamingHttpClientProxy.java
…ClientWorker.java
…ant/PropertiesConstant.java modified: config/src/main/java/com/alibaba/nacos/config/server/utils/PropertyUtil.java
…ClientWorker.java modified: client/src/main/java/com/alibaba/nacos/client/naming/remote/http/NamingHttpClientProxy.java
KomachiSion
requested changes
Nov 29, 2021
| @@ -113,7 +113,8 @@ | |||
| /** | |||
| * groupKey -> cacheData. | |||
| */ | |||
| private final AtomicReference<Map<String, CacheData>> cacheMap = new AtomicReference<>(new HashMap<>()); | |||
| private final AtomicReference<Map<String, CacheData>> cacheMap = new AtomicReference<Map<String, CacheData>>( | |||
Thank you for the heads up! There was something wrong with my workspace that caused java to default to an earlier version |
|
1 Do not use magic number |
|
|
|
CLA not sign for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To resolve issue #3046, unify the treatment of constant variables and reduce the usage of "magic numbers"
Brief changelog
Replacement of some of the usage of "magic numbers" for a cleaner and more maintainable approach and unify some discordand usages of the same variables
Verifying this change
eclipse-pmd was used to verify the changes