-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement for constant variables. #3046
Comments
public interface Constants {
interface Raft{
}
interface Nacos{
String FUNCTION_MODE_PROPERTY_NAME = "nacos.functionMode";
}
interface Web{
String ACCEPT_CHARSET = "Accept-Charset";
String SERVER_PORT = "server.port";
}
}
public class Constants {
public static class Raft{
}
public static class Nacos{
public static String FUNCTION_MODE_PROPERTY_NAME = "nacos.functionMode";
}
public static class Web{
public static String ACCEPT_CHARSET = "Accept-Charset";
public static String SERVER_PORT = "server.port";
}
} |
Looks great, but I can't get the difference between the two plan, I think plan two is more used. If you want to do this, please pay attention to the scope of these constants. |
ok i will do it |
@jzdayz Any progress? |
Sorry, in my idea, I want to put all the constants in common module, but I found that there are constant classes in different modules, so I think that if the code is modified, the range of changes will be larger. I think the code in the future It can be unified, but I dare not move the current code |
@jzdayz you can split this issue as multiple sub task. each module each task. And refactor for each module. |
For example:
|
OK,i got this , let me think , modify one by one |
@jzdayz There is no process for a long time, I unassign this issue for you first. If you want to solve it, please relay again with new process. |
@i will solve it@ |
This PR has no finished. |
Issue Description
Type: code review
Describe what happened (or what feature you want)
I noticed that there are some magic variables in applicationUtils and PropertyUtil, can it be written in one place,it's so messy. i think all config magic variables should be one place
Describe what you expected to happen
If it passes, I can do this
How to reproduce it (as minimally and precisely as possible)
Tell us your environment
Anything else we need to know?
The text was updated successfully, but these errors were encountered: