Resolve the issues of codestyle of nacos-config module for phase7 #3288
Conversation
| public static void verifyIncrementPubContent(String content) { | ||
|
|
There was a problem hiding this comment.
Please check indent in this file
| * | ||
| * @author Nacos | ||
| */ | ||
| @SuppressWarnings("checkstyle:ConstantName") |
There was a problem hiding this comment.
Why Add this suppress？
There was a problem hiding this comment.
Many Log member variables defined in this class are referenced in many classes. Do they need to be modified in code format?
There was a problem hiding this comment.
Use IDEA‘s refactor-rename feature, IDEA will help you change them all.
You just change the original location.
If you don't know how to use, doesn't matter. just remove the SuppressWarnings, I will fix it.
| * | ||
| * @author Nacos | ||
| */ | ||
| @SuppressWarnings("PMD.ClassNamingShouldBeCamelRule") | ||
| @SuppressWarnings({"PMD.ClassNamingShouldBeCamelRule", "checkstyle:MissingJavadocMethod"}) |
There was a problem hiding this comment.
Why skip MissingJavadocMethod check？
| @@ -74,6 +74,7 @@ public int incrementAndGet() { | |||
| return data[index].incrementAndGet(); | |||
| } | |||
|
|
|||
| @SuppressWarnings("checkstyle:MissingJavadocMethod") | |||
There was a problem hiding this comment.
Why add this SuppressWarnings？
| * | ||
| * @param regex | ||
| * @param regex regex | ||
| * @return |
There was a problem hiding this comment.
can this pass checkstyle？
| @@ -82,6 +83,7 @@ public int incrementAndGet(String ip) { | |||
| return data[index].incrementAndGet(); | |||
| } | |||
|
|
|||
| @SuppressWarnings("checkstyle:MissingJavadocMethod") | |||
There was a problem hiding this comment.
Why add this SuppressWarnings？
| @@ -71,6 +71,7 @@ public SimpleIPFlowData(int slotCount, int interval) { | |||
| timer.scheduleAtFixedRate(new DefaultIPFlowDataManagerTask(), interval, interval, TimeUnit.MILLISECONDS); | |||
| } | |||
|
|
|||
| @SuppressWarnings("checkstyle:MissingJavadocMethod") | |||
There was a problem hiding this comment.
Why add this SuppressWarnings？
| * | ||
| * @author leiwen.zh | ||
| */ | ||
| @SuppressWarnings("PMD.ClassNamingShouldBeCamelRule") | ||
| @SuppressWarnings({"PMD.ClassNamingShouldBeCamelRule", "checkstyle:AbbreviationAsWordInName"}) |
There was a problem hiding this comment.
Why add this SuppressWarnings？
There was a problem hiding this comment.
There are more than two consecutive uppercase letters in the class name, but IP is generally indicated with uppercase letters.
| * | ||
| * @author Nacos | ||
| */ | ||
| @SuppressWarnings("checkstyle:ConstantName") |
There was a problem hiding this comment.
Use IDEA‘s refactor-rename feature, IDEA will help you change them all.
You just change the original location.
If you don't know how to use, doesn't matter. just remove the SuppressWarnings, I will fix it.
| * | ||
| * @author leiwen.zh | ||
| */ | ||
| @SuppressWarnings("PMD.ClassNamingShouldBeCamelRule") | ||
| @SuppressWarnings({"PMD.ClassNamingShouldBeCamelRule", "checkstyle:AbbreviationAsWordInName"}) |
|
Refer #3249 |
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Resolve the issues of codestyle of nacos-config module for some package parts below.
Package:
(1)com.alibaba.nacos.config.server.utils
(2)com.alibaba.nacos.config.server.utils.event
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.