Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the issues of codestyle of nacos-config module. #3249

Closed
zongtanghu opened this issue Jul 4, 2020 · 1 comment
Closed

Resolve the issues of codestyle of nacos-config module. #3249

zongtanghu opened this issue Jul 4, 2020 · 1 comment
Assignees
@zongtanghu
Labels
area/Nacos Core kind/code quality
Milestone
1.3.1

Comments

@zongtanghu
Copy link
Collaborator

Issue Description

Type: feature request

Describe what happened (or what feature you want)

(1).Resolve the issue of codestyle in the nacos-config module.
(2).You can see the related issue's link: #2992.

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@KomachiSion
Copy link
Collaborator

I think you can make the issue as multiple tasks.

@KomachiSion KomachiSion added this to the 1.3.1 milestone Jul 6, 2020
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jul 7, 2020
@zongtanghu
[alibaba#3249]Fix chinese unit method name in config test module.
5fa364c
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jul 7, 2020
@zongtanghu
[alibaba#3249]resolve the code style issue in service package.
a18c2ed
KomachiSion pushed a commit that referenced this issue Jul 8, 2020
@zongtanghu
Resolve the issues of codestyle of nacos-config module for phase5. (#…
0086dfe 
…3272)

* [#3249]Fix chinese unit method name in config test module.

* [#3249]resolve the code style issue in service package.

* [ISSUE#3249]fix typo.
wangweizZZ added a commit to wangweizZZ/nacos that referenced this issue Jul 8, 2020
@wangweizZZ
[alibaba#3249]Resolve the issues of codestyle of nacos-config module …
a4f5ba5 
…for phase6

Change-Id: I731548ea51b8ccf2a7f2635bd0e864573ccc7fc9
KomachiSion pushed a commit that referenced this issue Jul 8, 2020
@wangweizZZ
[#3249]Resolve the issues of codestyle of nacos-config module for pha…
9e9b95b 
…se6 (#3277)

Change-Id: I731548ea51b8ccf2a7f2635bd0e864573ccc7fc9
This was referenced Jul 10, 2020
Closed
Merged
This was referenced Jul 10, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zongtanghu zongtanghu

Labels
area/Nacos Core kind/code quality
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
2 participants
@zongtanghu @KomachiSion