-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:add param for ConfigInfoMapperByMySql#findAllConfigInfoBaseFetchRows #11883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong fix way, please keep the ?
to avoid SQL security problem.
I have found SQL security issues elsewhere, and I will fix them together |
|
other mapper class all have this problem |
For pagination parameters, basically no ? are retained to avoid SQL security problem |
These implementation all has problem, we should add a new issue to mark the problem and fix them together. First to fix this issue, and please @publicize-y to create new issue to describe this after PR merged. |
@publicize-y CI and IT can't pass, maybe some check can't pass. And more thing which you shou add some UT for your change codes. |
ok,i get it |
There is already a unit test, do I need to write another one |
and the logic seems to not require modification |
If UT has exist and covered your method, UT might can't pass, because your code change the return value for this method. |
Ignore it , I found you has change the UT case. plugin/datasource/src/test/java/com/alibaba/nacos/plugin/datasource/impl/mysql/ConfigInfoMapperByMySqlTest.java |
CI still not pass you can use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11883 +/- ##
=============================================
+ Coverage 68.42% 68.58% +0.15%
- Complexity 8989 9031 +42
=============================================
Files 1239 1239
Lines 40573 40613 +40
Branches 4317 4322 +5
=============================================
+ Hits 27761 27853 +92
+ Misses 10821 10760 -61
- Partials 1991 2000 +9
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
link #11859
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.