fix：add param for ConfigInfoMapperByMySql#findAllConfigInfoBaseFetchR…

…ows (#11883) * fix：add param for ConfigInfoMapperByMySql#findAllConfigInfoBaseFetchRows * fix：code style modify * fix：code style modify * fix：code style modify --------- Co-authored-by: zhangyang <1445621702@qq.com>
alibaba · Apr 2, 2024 · facf4c8 · facf4c8
1 parent 19a857b
commit facf4c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...src/main/java/com/alibaba/nacos/plugin/datasource/impl/mysql/ConfigInfoMapperByMySql.java b/...src/main/java/com/alibaba/nacos/plugin/datasource/impl/mysql/ConfigInfoMapperByMySql.java
@@ -85,8 +85,8 @@ public MapperResult findAllConfigKey(MapperContext context) {
     @Override
     public MapperResult findAllConfigInfoBaseFetchRows(MapperContext context) {
         String sql = "SELECT t.id,data_id,group_id,content,md5"
-                + " FROM ( SELECT id FROM config_info ORDER BY id LIMIT ?,?  ) "
-                + " g, config_info t  WHERE g.id = t.id ";
+                + " FROM ( SELECT id FROM config_info ORDER BY id LIMIT " + context.getStartRow() + ","
+                + context.getPageSize() + " )" + " g, config_info t  WHERE g.id = t.id ";
         return new MapperResult(sql, Collections.emptyList());
     }
 

diff --git a/...test/java/com/alibaba/nacos/plugin/datasource/impl/mysql/ConfigInfoMapperByMySqlTest.java b/...test/java/com/alibaba/nacos/plugin/datasource/impl/mysql/ConfigInfoMapperByMySqlTest.java
@@ -143,8 +143,8 @@ public void testFindAllConfigKey() {
     public void testFindAllConfigInfoBaseFetchRows() {
         MapperResult mapperResult = configInfoMapperByMySql.findAllConfigInfoBaseFetchRows(context);
         Assert.assertEquals(mapperResult.getSql(),
-                "SELECT t.id,data_id,group_id,content,md5 FROM ( SELECT id FROM config_info ORDER BY id LIMIT ?,?"
-                        + "  )  g, config_info t  WHERE g.id = t.id ");
+                "SELECT t.id,data_id,group_id,content,md5 FROM ( SELECT id FROM config_info ORDER BY id LIMIT " + context.getStartRow() + ","
+                        + context.getPageSize() + " ) g, config_info t  WHERE g.id = t.id ");
         Assert.assertArrayEquals(mapperResult.getParamList().toArray(), emptyObjs);
     }