GraphScope 1/3: Enable macos compatibility#208
Merged
sighingnow merged 2 commits intoalibaba:masterfrom Jul 21, 2022
Merged
Conversation
Signed-off-by: Tao He <sighingnow@gmail.com>
Collaborator
goldenleaves
left a comment
There was a problem hiding this comment.
I think that it is better to put this cmake folder in the upper directory, because thrid parties are currently being sharedby graphlearn module and dgs module.
Collaborator
Author
Okay |
Signed-off-by: Tao He <sighingnow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebase & merge graphscope task will include three pull requests to make code review easier:
This pull request is the first one of the patch series, includes:
tr1as we have already moved to C++14 in CMakeLists.txt