GraphScope 2/3: (graph-learn on vineyard) use vineyard fragment as the underlying graph.#210
Merged
sighingnow merged 7 commits intoalibaba:masterfrom Aug 3, 2022
Merged
Conversation
sighingnow
force-pushed
the
ht/macos
branch
2 times, most recently
from
4dfd1de to
4efd33a
Compare
Signed-off-by: Tao He <sighingnow@gmail.com>
sighingnow
changed the title
Seventeen17
reviewed
Aug 2, 2022
graphlearn/src/core/graph/graph.h
Outdated
| Graph* CreateRemoteGraph(); | ||
| Graph* CreateLocalGraph(const std::string& type, | ||
| std::string const &view_type, | ||
| std::string const &use_attrs); |
Collaborator
There was a problem hiding this comment.
I think it's better to use const T& for keeping consistency.
| // if (stopped_.load()) { | ||
| // return Status::OK(); | ||
| // } | ||
| stopped_.store(true); |
Collaborator
There was a problem hiding this comment.
The stopped_ flag is to record the channel stopped state that I can see, so it seems that we should move the setting of stopped_ after HandleStop
baoleai
reviewed
Aug 2, 2022
Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
baoleai
reviewed
Aug 3, 2022
…n about edges. Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
baoleai
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.