fix collect heap-use-after-free#412
Merged
ChuanqiXu9 merged 2 commits intoalibaba:mainfrom Jan 20, 2025
Merged
Conversation
ChuanqiXu9
approved these changes
Jan 16, 2025
ChuanqiXu9
requested changes
Jan 16, 2025
Collaborator
ChuanqiXu9
left a comment
ChuanqiXu9
left a comment
There was a problem hiding this comment.
Please fix test failures
Collaborator
Author
|
@ChuanqiXu9 all CI passed |
ChuanqiXu9
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The prev pull requests #402 may cause heap-use-after-free due to some error operation in collectAny
What is changing
Fix bug by move variable into await_suspend() function's stack local variable
Example