Conversation
poor-circle
force-pushed
the
cancel_expermential
branch
from
44d03d8 to
a1610ed
Compare
poor-circle
force-pushed
the
cancel_expermential
branch
3 times, most recently
from
1bf6f5a to
77c1a8d
Compare
poor-circle
force-pushed
the
cancel_expermential
branch
from
1c265b1 to
ea5aa7d
Compare
|
|
poor-circle
force-pushed
the
cancel_expermential
branch
from
41db3d6 to
c7a2da5
Compare
|
@ChuanqiXu9 It seems that mac ci & bazel ci are broken. |
CC @PikachuHyA |
|
@ChuanqiXu9 All conversation resolved. |
| virtual ~Signal(); | ||
|
|
||
| private: | ||
| std::atomic<uint64_t> _state; |
There was a problem hiding this comment.
Where is the intialization? And what's the meaning of _state? The latt emitted signal type? Can a Signal emit multiple times?
There was a problem hiding this comment.
Default state is zero. It means which signal has triggered. It was updated at UpdateState. If a signal is low 32bits, it can't emit multiple times. I have add some comments.
| std::atomic<Node*> _slotsHead; | ||
| }; | ||
|
|
||
| class Slot { |
| syncAwait(testCollectAllPara().via(&e1)); | ||
| } | ||
|
|
||
| TEST_F(LazyTest, testCollectAnyWithCallbackVariadic) { |
There was a problem hiding this comment.
Please not touch the previous test if the API remains
There was a problem hiding this comment.
Can we remain the test?
|
@ChuanqiXu9 new conversation is fixed |
3 participants
Why
See document
What is changing
Breakchanges:
spinlockmay throw exceptions.CollectAll/CollectAnyhave been changed to lazy, and the callback versions ofcollectAll/collectAnyhave been removed.