Enhancement/normalize metric field #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename exception to exceptionQps; remove ed postfix of all field in metrics.
rename exception to exceptionQps; remove ed postfix of all field in metrics.
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
============================================
+ Coverage 51.15% 51.46% +0.31%
- Complexity 822 829 +7
============================================
Files 139 139
Lines 4737 4737
Branches 672 672
============================================
+ Hits 2423 2438 +15
+ Misses 2030 2009 -21
- Partials 284 290 +6
Continue to review full report at Codecov.
|
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
normalize metric fields and methods: - rename exception to exceptionQps; - remove ed postfix of all fields and methods about metrics;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Some field name or method name about metric is ambiguous or inconsistent, for example the
MetricNode.exceptionis in factexceptionQpsother than total exception count, method nameNode.blockedQps()andNode.passQps()are not in the save tense.This may increase understanding costs and lead misuse of monitoring information.
Does this pull request fix one issue?
Fixes #169
Describe how you did it
Refactor the field and method names in
MetricNode,Node,NodeVo, etc. to make it clear.Describe how to verify it
None.
Special notes for reviews
Invite @konglz to review the code.