Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize field and method names about metric #169

Closed
CarpenterLee opened this issue Oct 10, 2018 · 0 comments · Fixed by #170
Closed

Normalize field and method names about metric #169

CarpenterLee opened this issue Oct 10, 2018 · 0 comments · Fixed by #170
Labels
kind/enhancement Category issues or prs related to enhancement.
Milestone
1.3.0

Comments

@CarpenterLee
Copy link
Contributor

Issue Description

Type: enhancement

Describe what happened (or what feature you want)

Some field name or method name about metric is ambiguous or inconsistent, for example the MetricNode.exception is in fact exceptionQps other than total exception count, method nameNode.blockedQps() and Node.passQps() are not in the save tense.

This may increase understanding costs and lead misuse of monitoring information.

Describe what you expected to happen

Normalize field and method names about metric.
@CarpenterLee CarpenterLee mentioned this issue Oct 10, 2018
Merged
@CarpenterLee CarpenterLee added the kind/enhancement Category issues or prs related to enhancement. label Oct 10, 2018
@sczyh30 sczyh30 added this to the 0.2.1 milestone Oct 11, 2018
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@lindzh @zhouxinyu
[ROCKETMQ-292] Delete system.exit in MQAdminStartup
8c30310 
Author: lindzh <linsony0@163.com>

Closes alibaba#169 from lindzh/fix_main_system.exit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Enhancement/normalize metric field alibaba/Sentinel
2 participants
@sczyh30 @CarpenterLee