Skip to content

fix: fix parsing of PC when a inner transaction fails #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented May 9, 2025

Previously the outer PC was getting used to determine the error for the inner app. This PR fixes that. Tests ensure that it works for inner failures, even with multiple levels of calls.

Fixes #396

@lempira lempira self-requested a review May 9, 2025 20:01
@joe-p joe-p merged commit 1df9623 into main May 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppClient doesn't return custom error message when called via inner txn
2 participants