AppClient doesn't return custom error message when called via inner txn

[gidonkatten]

Subject of the issue

PuyaPy contract called by inner txn doesn't provide custom error messages.

Your environment

AlgoKit: 2.6.2

Steps to reproduce

See https://gist.github.com/gidonkatten/be6fe0bd55fbe92c013a229376b2b54e containing:

• Test.py which contains the two contracts
• test.ts which contains the tests

Actual behaviour

When running the file test.ts with `jest, the test with the inner txn calls fails:

Expected substring: "custom error message"
Received message:   "inner tx 0 failed: logic eval error: err opcode executed. Details: app=1188, pc=29, opcodes=txn ApplicationID; assert; err; label1:. at:43. Network request error. Received status 400 (Bad Request): TransactionPool.Remember: transaction BGIMPNJZDGHKOERORFGHDV6SSQQ3MEYSCKP5GJXOKXE62JVFXODA: logic eval error: inner tx 0 failed: logic eval error: err opcode executed. Details: app=1188, pc=29, opcodes=txn ApplicationID; assert; err; label1:. Details: app=1189, pc=56, opcodes=intc_0 // 0; itxn_field Fee; itxn_submit"

Expected behaviour

Both tests to pass

[gidonkatten]

@neilcampbell not sure if the issue belongs here or in algokit-utils-ts, either way can you please provide an ETA for a fix?

[lempira]

Hi @gidonkatten, we are looking into this one. There seems to be a fix already in this PR, but we need to verify that. If that works, there should be a fix today or tomorrow. If not, it'll be next week.

[joe-p]

@gidonkatten Should be merged/released shortly. Just want to note that once this is merged you need to instantiate a client for the inner app (with its app ID), even if you aren't directly using it. Basically once you instantiate an app client Algokit will remember how to resolve errors for the app even if you are using a completely different app client to send the outer call.

[gidonkatten]

Thanks @joe-p @lempira, should this issue #394 also be resolved from the same PR?

[joe-p]

Update: it's been merged but we realized that there's a small bug in parsing the error message from an inner failure. Algokit is getting the PC for the outer but we need the PC for the inner. Should be a quick fix, but you will need to wait for the next release. Should be out today