daemon: pool error messages and old txn expiration #4755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4755 +/- ##
=======================================
Coverage 54.59% 54.59%
=======================================
Files 414 414
Lines 53665 53665
=======================================
Hits 29297 29297
Misses 21945 21945
Partials 2423 2423 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jasonpaulos
previously approved these changes
Nov 4, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Seems reasonable to me
cce
reviewed
Nov 4, 2022
cce
reviewed
Nov 4, 2022
cce
reviewed
Nov 4, 2022
algorandskiy
force-pushed
the
txn-pool-error
branch
from
af35e7d to
6606939
Compare
Contributor
Author
|
ok, removed the statusCache pruning |
jasonpaulos
approved these changes
Nov 4, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
I think this is good to take as is. I didn't open a PR for the original issue because I wanted to find a way of testing the change, but I don't think that's worth waiting for.
This was referenced Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transaction pools might store failed transactions for quite a long time on its StatusCache.
When someone requests a pending transaction and it gets retrieved from the StatusCache,
there is no indication it actually failed. A user might have an impression the txn is fine but stuck.
In order to give a correct feedback, report any errors from the StatusCache via REST API.