daemon: add pool error message #4635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
approved these changes
Oct 11, 2022
|
We are encountering issues with this and could really use a quick resolution. |
Contributor
Author
|
Replaced by #4755 (rebased, added cache pruning) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transaction pools might store failed transactions for quite a long time on its StatusCache. When someone requests a pending transaction and it gets retrieved from the StatusCache, there is no indication it actually failed. A user might have an impression the txn is fine but stuck.
In order to give a correct feedback, report any errors from the StatusCache via REST API.
Test Plan
TODO