code review

[jannotti]

some specs, tests, cast, deadcode

[codecov]

Codecov Report

Merging #4709 (b396eeb) into feature/avm-box (260e226) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           feature/avm-box    #4709      +/-   ##
===================================================
- Coverage            54.30%   54.25%   -0.05%     
===================================================
  Files                  416      413       -3     
  Lines                53410    53390      -20     
===================================================
- Hits                 29005    28968      -37     
- Misses               22021    22027       +6     
- Partials              2384     2395      +11     

Impacted Files	Coverage Δ
ledger/internal/applications.go	3.87% <ø> (ø)
data/transactions/logic/box.go	95.20% <100.00%> (ø)
util/db/dbutil.go	42.60% <0.00%> (-6.51%)	⬇️
util/metrics/reporter.go	56.31% <0.00%> (-4.86%)	⬇️
logging/telemetryFilteredHook.go	86.66% <0.00%> (-3.34%)	⬇️
cmd/algoh/blockWatcher.go	77.77% <0.00%> (-3.18%)	⬇️
ledger/blockqueue.go	85.63% <0.00%> (-2.88%)	⬇️
catchup/service.go	68.88% <0.00%> (-1.98%)	⬇️
cmd/tealdbg/dryrunRequest.go	53.70% <0.00%> (-1.86%)	⬇️
util/metrics/counter.go	88.04% <0.00%> (-1.09%)	⬇️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michaeldiamant]

Addresses these threads:

• #4149 (comment)
• #4149 (comment)

Though I do not see any specs changes here.