Merge pull request #4709 from jannotti/box-specs-review

code review

Author: jannotti

data/transactions/logic/box.go

@@ -154,7 +154,7 @@ func opBoxExtract(cx *EvalContext) error {
 		return fmt.Errorf("no such box %#v", name)
 	}
 
-	bytes, err := extractCarefully([]byte(contents), start, length)
+	bytes, err := extractCarefully(contents, start, length)
 	cx.stack[pprev].Bytes = bytes
 	cx.stack = cx.stack[:prev]
 	return err
@@ -182,7 +182,7 @@ func opBoxReplace(cx *EvalContext) error {
 		return fmt.Errorf("no such box %#v", name)
 	}
 
-	bytes, err := replaceCarefully([]byte(contents), replacement, start)
+	bytes, err := replaceCarefully(contents, replacement, start)
 	if err != nil {
 		return err
 	}

data/transactions/logic/ledger_test.go

@@ -898,11 +898,6 @@ func (l *Ledger) Perform(gi int, ep *EvalParams) error {
 	}
 }
 
-// Get() through allocated() implement cowForLogicLedger, so we should
-// be able to make logicLedger with this inside.  That let's us to
-// write tests and then poke around and see how the balance table
-// inside is affected.
-
 // Get returns the AccountData of an address. This test ledger does
 // not handle rewards, so the pening rewards flag is ignored.
 func (l *Ledger) Get(addr basics.Address, withPendingRewards bool) (basics.AccountData, error) {

data/transactions/logic/parsing_test.go

@@ -21,11 +21,12 @@ import (
 	"encoding/base64"
 	"encoding/binary"
 	"fmt"
-	"github.com/algorand/avm-abi/abi"
-	"github.com/algorand/go-algorand/data/basics"
 	"math"
 	"testing"
 
+	"github.com/algorand/avm-abi/abi"
+	"github.com/algorand/go-algorand/data/basics"
+
 	"github.com/algorand/go-algorand/test/partitiontest"
 	"github.com/stretchr/testify/require"
 )
@@ -91,18 +92,6 @@ func TestNewAppCallBytes(t *testing.T) {
 		}
 	}
 
-	for _, v := range []uint64{1, 0, math.MaxUint64} {
-		for _, e := range []string{"int", "integer"} {
-			t.Run(fmt.Sprintf("encoding=%v,value=%v", e, v), func(t *testing.T) {
-				acb, err := NewAppCallBytes(fmt.Sprintf("%v:%v", e, v))
-				require.NoError(t, err)
-				r, err := acb.Raw()
-				require.NoError(t, err)
-				require.Equal(t, v, binary.BigEndian.Uint64(r))
-			})
-		}
-	}
-
 	for _, v := range []string{"737777777777777777777777777777777777777777777777777UFEJ2CI"} {
 		for _, e := range []string{"addr", "address"} {
 			t.Run(fmt.Sprintf("encoding=%v,value=%v", e, v), func(t *testing.T) {

ledger/internal/applications.go

@@ -21,7 +21,6 @@ import (
 
 	"github.com/algorand/go-algorand/data/basics"
 	"github.com/algorand/go-algorand/data/bookkeeping"
-	"github.com/algorand/go-algorand/data/transactions"
 	"github.com/algorand/go-algorand/data/transactions/logic"
 	"github.com/algorand/go-algorand/ledger/apply"
 	"github.com/algorand/go-algorand/ledger/ledgercore"
@@ -31,28 +30,6 @@ import (
 /* This file adds functions to roundCowState that make it more palatable for use
    outside of the ledger package. The LedgerForLogic interface expects them. */
 
-type cowForLogicLedger interface {
-	Get(addr basics.Address, withPendingRewards bool) (ledgercore.AccountData, error)
-	GetAppParams(addr basics.Address, aidx basics.AppIndex) (basics.AppParams, bool, error)
-	GetAssetParams(addr basics.Address, aidx basics.AssetIndex) (basics.AssetParams, bool, error)
-	GetAssetHolding(addr basics.Address, aidx basics.AssetIndex) (basics.AssetHolding, bool, error)
-	GetCreator(cidx basics.CreatableIndex, ctype basics.CreatableType) (basics.Address, bool, error)
-	GetKey(addr basics.Address, aidx basics.AppIndex, global bool, key string, accountIdx uint64) (basics.TealValue, bool, error)
-	BuildEvalDelta(aidx basics.AppIndex, txn *transactions.Transaction) (transactions.EvalDelta, error)
-
-	SetKey(addr basics.Address, aidx basics.AppIndex, global bool, key string, value basics.TealValue, accountIdx uint64) error
-	DelKey(addr basics.Address, aidx basics.AppIndex, global bool, key string, accountIdx uint64) error
-
-	round() basics.Round
-	prevTimestamp() int64
-	allocated(addr basics.Address, aidx basics.AppIndex, global bool) (bool, error)
-	txnCounter() uint64
-	incTxnCount()
-
-	// The method should use the txtail to ensure MaxTxnLife+1 headers back are available
-	blockHdrCached(round basics.Round) (bookkeeping.BlockHeader, error)
-}
-
 func (cs *roundCowState) AccountData(addr basics.Address) (ledgercore.AccountData, error) {
 	record, err := cs.Get(addr, true)
 	if err != nil {