Skip to content

Conversation

@Algo-devops-service
Copy link
Contributor

@Algo-devops-service Algo-devops-service commented Oct 20, 2022

GitHub Logo

Overview

When an account had many resources, it could break catching up from a catchpoint. This release fixes this issue.

What's New

  • Bug fix for catchpoint catchup
  • Fix for garbage collection in batch verifier
  • Other small enhancements and fixes

Changelog

Enhancements

  • Pingpong: add genaccountsoffset flag and tool to print test account addresses (#4628)
  • V1 Deprecation: Remove algod and kmd client affinity and consolidate APIs to use newest version (#4641)

Bugfixes

  • Batchverifier: preserve the memory until the end (#4672)
  • Catchpoints: don't make duplicate account hashes in prepareNormalizedBalances (#4668)
  • Pingpong: fix config check for GeneratedAccountsMnemonics (#4662)

Protocol Upgrade

This release does not contain a protocol upgrade.

Additional Resources

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #4677 (bc845d7) into rel/stable (e1b890a) will decrease coverage by 0.39%.
The diff coverage is 75.92%.

@@              Coverage Diff               @@
##           rel/stable    #4677      +/-   ##
==============================================
- Coverage       54.52%   54.12%   -0.40%     
==============================================
  Files             406      403       -3     
  Lines           51937    51934       -3     
==============================================
- Hits            28318    28111     -207     
- Misses          21264    21441     +177     
- Partials         2355     2382      +27     
Impacted Files Coverage Δ
cmd/goal/commands.go 10.44% <ø> (+0.03%) ⬆️
libgoal/libgoal.go 2.70% <ø> (+0.02%) ⬆️
shared/pingpong/accounts.go 3.20% <0.00%> (-0.08%) ⬇️
shared/pingpong/config.go 0.00% <0.00%> (ø)
crypto/batchverifier.go 100.00% <100.00%> (ø)
ledger/accountdb.go 72.22% <100.00%> (-0.66%) ⬇️
ledger/catchupaccessor.go 62.40% <100.00%> (+0.36%) ⬆️
daemon/algod/api/server/lib/middlewares/auth.go 0.00% <0.00%> (-100.00%) ⬇️
data/bookkeeping/genesis.go 0.00% <0.00%> (-26.67%) ⬇️
util/db/initialize.go 68.75% <0.00%> (-18.75%) ⬇️
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algojack algojack closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants