Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Oct 5, 2022

Summary

This adds -genaccountsoffset which complements -genaccounts and set the existing PpCfg.GeneratedAccountsOffset and PpCfg.GeneratedAccountsCount fields, respectively. It also adds a tool to print the test addresses used for pingpong tests using these arguments.

It also adds a "GeneratedAccountsMnemonics" config key that can be passed via -config filename.json -numaccounts X -gensamplemethod mnemonic to provide a list of account mnemonics to use with pingpong.

Test Plan

Can test by running pingpong with these flags.

@cce cce added the Enhancement label Oct 5, 2022
@cce cce force-pushed the more-pingpong-deterministic branch from ee0ab37 to ca0b520 Compare October 5, 2022 20:07
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #4628 (e38f81a) into master (fdef01f) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4628      +/-   ##
==========================================
+ Coverage   54.18%   54.21%   +0.02%     
==========================================
  Files         402      402              
  Lines       51828    51839      +11     
==========================================
+ Hits        28084    28104      +20     
+ Misses      21379    21374       -5     
+ Partials     2365     2361       -4     
Impacted Files Coverage Δ
shared/pingpong/accounts.go 3.20% <0.00%> (-0.08%) ⬇️
shared/pingpong/config.go 0.00% <0.00%> (ø)
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
data/transactions/verify/txn.go 46.19% <0.00%> (-0.96%) ⬇️
catchup/service.go 68.88% <0.00%> (+0.24%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/blockqueue.go 88.50% <0.00%> (+2.87%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce cce requested a review from brianolson October 6, 2022 11:07
Copy link
Contributor

@algolucky algolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

been using this for live load generation.

@cce cce merged commit b29d7ff into algorand:master Oct 17, 2022
@cce cce deleted the more-pingpong-deterministic branch October 17, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants