AVM: FIDO2 OpCodes #3514
Merged
AVM: FIDO2 OpCodes #3514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Mar 9, 2022
tzaffi
commented
Mar 9, 2022
jannotti
reviewed
Mar 9, 2022
jannotti
reviewed
Mar 9, 2022
jannotti
reviewed
Mar 9, 2022
jannotti
reviewed
Mar 9, 2022
Contributor
There was a problem hiding this comment.
I think this is good. Note to further reviewers: This PR is NOT intended to cause any changes in the current protocol or even, really, in vFuture. These opcodes needs to be gated so that the new opcodes only get turned on by testers who want it (we will maintain a small feature branch with the changes to turn them on).
With that in mind, I think fidoVersion should be set to LogicSigVersion+1 before merging. (And set to LogicSigVersion only in the small feature branch.)
tzaffi
commented
Mar 9, 2022
tzaffi
commented
Mar 10, 2022
tzaffi
commented
Mar 10, 2022
jannotti
approved these changes
Mar 10, 2022
jannotti
pushed a commit
to jannotti/go-algorand
that referenced
this pull request
Mar 13, 2022
Three opcodes that all pertain to FIDO2 authorization. They are slated for Teal7 here, but they can be delayed by changing fidoVersion. Co-authored-by: Igor Durovic <igor.durovic@algorand.com> Co-authored-by: algoidurovic <91566643+algoidurovic@users.noreply.github.com> Co-authored-by: shiqi.zheng@algorand.com <shiqi.zheng@algorand.com>
Merged
This was referenced Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental FIDO2 OpCodes
This is a branch containing OpCodes which are needed for FIDO2 authentication:
base64_decodejson_refecdsa_*opcodes for new curveSecp256r1The usage patterns are not set in stone and these op codes may change before being released.
Note
This PR is NOT intended to cause any changes in the current protocol or even, really, in vFuture. These opcodes need to be gated so that the new opcodes only get turned on by testers who want it (we will maintain a small feature branch with the changes to turn them on).
TESTING
b38c152cwithfidoVersion = 7passes all testsd566072bwithfidoVersion = LogicVersion + 1passes all tests