-
Notifications
You must be signed in to change notification settings - Fork 524
[WIP] Secp256r1 support for ECDSA verify and decompress opcodes #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
From doc.go for
I suspect these constraints might not be true for the secp256r1 curve. And if that's the case we should document it (or decide to enforce them). |
…evious LogicVersion's
…into secp256r1
…to fido2-future
…s meant to be reserved for the fido2 experimental branch
a3c6678 to
a2420f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #3495 +/- ##
==========================================
- Coverage 47.57% 47.46% -0.11%
==========================================
Files 370 370
Lines 60060 60213 +153
==========================================
+ Hits 28572 28579 +7
- Misses 28178 28323 +145
- Partials 3310 3311 +1
Continue to review full report at Codecov.
|
|
Closing because:
|
ECDSA opcodes only support the Secp256k1 curve. The goal of this PR is to extend the opcodes to support the Secp256r1 curve as well. Note: the PkRecover opcode is not covered here.
Testing included correctness and benchmark tests. Benchmark tests indicate a significant slowdown when the Secp256r1 curve is used, meaning the current opcode cost may not be viable.
Added some helper test functions.