Skip to content

Conversation

@AlgoStephenAkiki
Copy link
Contributor

@AlgoStephenAkiki AlgoStephenAkiki commented Jan 6, 2022

Resolves #2934

#2394

Fix the unit test TestAsyncTelemetryHook_QueueDepth:

// the anonymous goroutine in createAsyncHookLevels might pull an entry off the pending list before
// writing it off to the underlying hook. when that happens, the total number of sent entries could
// be one higher then the maxDepth.

Summary

Test Plan

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #3382 (fee561a) into master (52a1a2c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
+ Coverage   47.66%   47.67%   +0.01%     
==========================================
  Files         370      370              
  Lines       59793    59793              
==========================================
+ Hits        28499    28506       +7     
+ Misses      27982    27980       -2     
+ Partials     3312     3307       -5     
Impacted Files Coverage Δ
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
data/transactions/verify/txn.go 44.29% <0.00%> (ø)
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
ledger/blockqueue.go 85.05% <0.00%> (+2.87%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a1a2c...fee561a. Read the comment docs.

@algorandskiy
Copy link
Contributor

Alternative implementation #2685

@winder
Copy link
Contributor

winder commented Jan 7, 2022

Yes, Stephen was trying out a couple of versions of this fix. Looks like Tsachi's original approach is the way to go. I'll close this PR and we can merge in #2685

@winder winder closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants