Rotate Travis Env Variables and Remove codecov Env variable #2934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algobarb
requested review from
algojack,
bricerisingalgorand,
egieseke,
onetechnical and
tsachiherman
Codecov Report
@@ Coverage Diff @@
## master #2934 +/- ##
===========================================
- Coverage 47.29% 37.17% -10.12%
===========================================
Files 355 353 -2
Lines 57182 57164 -18
===========================================
- Hits 27043 21251 -5792
- Misses 27079 33163 +6084
+ Partials 3060 2750 -310
Continue to review full report at Codecov.
|
onetechnical
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rotated slack token in environment variable and removed the codecov token from Travis file. codecov token is removed because it's not needed for public repos.
Test Plan
Check that tests are still passing with the new change. Unable to test the impact on slack alerts on rel/nightly, but the impact should be quite low. Also am using a branch rather than a forked repo since I am modifying travis environment variables.