Relstable3.2.3 remerge #3372
Merged
Relstable3.2.3 remerge #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ## Summary This PR moves the catchpoint file writing to be performed outside of the trackers lock. This resolves the issue where a long catchpoint file writing blocks the agreement from validating and propagating votes. ## Test Plan * [x] Test manually & use existing tests. * [x] Implement a unit test * [x] Deploy a local network where the catchpoint writing takes a long time and verify it doesn't get blocked during catchpoint writing.
go-algorand v3.2.3-beta
go-algorand 3.2.3-stable
Codecov Report
@@ Coverage Diff @@
## master #3372 +/- ##
==========================================
- Coverage 47.65% 37.67% -9.99%
==========================================
Files 369 367 -2
Lines 59660 59642 -18
==========================================
- Hits 28433 22470 -5963
- Misses 27914 34216 +6302
+ Partials 3313 2956 -357
Continue to review full report at Codecov.
|
Contributor
|
|
onetechnical
approved these changes
Jan 5, 2022
Contributor
No because the minor version was already bumped to 3 by 3.2.1-stable. |
tsachiherman
approved these changes
Jan 6, 2022
egieseke
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge back 3.2.3 stable code to keep commits aligned in master branch.