go-algorand 3.2.3-stable #3356
Merged
go-algorand 3.2.3-stable #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ## Summary This PR moves the catchpoint file writing to be performed outside of the trackers lock. This resolves the issue where a long catchpoint file writing blocks the agreement from validating and propagating votes. ## Test Plan * [x] Test manually & use existing tests. * [x] Implement a unit test * [x] Deploy a local network where the catchpoint writing takes a long time and verify it doesn't get blocked during catchpoint writing.
go-algorand v3.2.3-beta
Codecov Report
@@ Coverage Diff @@
## rel/stable #3356 +/- ##
==============================================
+ Coverage 47.34% 47.47% +0.12%
==============================================
Files 369 369
Lines 59649 59652 +3
==============================================
+ Hits 28243 28318 +75
+ Misses 28122 28045 -77
- Partials 3284 3289 +5
Continue to review full report at Codecov.
|
onetechnical
requested review from
algobarb,
algojack,
bricerisingalgorand,
egieseke and
tsachiherman
algojack
approved these changes
Jan 4, 2022
algobarb
approved these changes
Jan 4, 2022
egieseke
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
3.2.1 introduced a minor delay whenever a catchpoint was generated every 10,000 rounds. This fix resolves that issue for nodes that have catchpoint generation enabled (e.g. archival nodes).
Changelog
Protocol Upgrade
This release does not contain a protocol upgrade.
Additional Resources