Skip to content

Conversation

@winder
Copy link
Contributor

@winder winder commented Nov 2, 2021

Summary

Note: This is a draft because it depends on/includes changes in #3148 which have not been merged yet.

First tests using dev-mode and the new participation key rest API's to write more focused tests.

Test Plan

These are tests.

node/node.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also found a bug, this was causing the wrong "EffectiveRound" variables to be set in the registry.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #3178 (fee748f) into feature/partkey (3c391eb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feature/partkey    #3178      +/-   ##
===================================================
- Coverage            44.12%   44.10%   -0.02%     
===================================================
  Files                  394      394              
  Lines                87648    87663      +15     
===================================================
- Hits                 38671    38667       -4     
- Misses               42885    42903      +18     
- Partials              6092     6093       +1     
Impacted Files Coverage Δ
cmd/goal/account.go 14.04% <0.00%> (ø)
libgoal/libgoal.go 2.93% <0.00%> (-0.09%) ⬇️
node/node.go 24.22% <0.00%> (ø)
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
ledger/tracker.go 73.33% <0.00%> (-2.86%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
network/wsPeer.go 73.06% <0.00%> (ø)
catchup/service.go 69.82% <0.00%> (+0.74%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c391eb...fee748f. Read the comment docs.

@winder winder force-pushed the will/devmode-partkey-tests branch from b412dff to 9400b64 Compare November 2, 2021 20:19
@winder winder marked this pull request as draft November 2, 2021 20:20
@winder winder marked this pull request as ready for review November 3, 2021 15:48
@winder winder merged commit afcf507 into algorand:feature/partkey Nov 3, 2021
@winder winder deleted the will/devmode-partkey-tests branch November 3, 2021 17:26
@winder winder linked an issue Nov 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DevMode Participation Key Tests

2 participants