-
Notifications
You must be signed in to change notification settings - Fork 523
Add new participation key e2e test. #3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new participation key e2e test. #3178
Conversation
node/node.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also found a bug, this was causing the wrong "EffectiveRound" variables to be set in the registry.
Codecov Report
@@ Coverage Diff @@
## feature/partkey #3178 +/- ##
===================================================
- Coverage 44.12% 44.10% -0.02%
===================================================
Files 394 394
Lines 87648 87663 +15
===================================================
- Hits 38671 38667 -4
- Misses 42885 42903 +18
- Partials 6092 6093 +1
Continue to review full report at Codecov.
|
b412dff to
9400b64
Compare
Summary
Note: This is a draft because it depends on/includes changes in #3148 which have not been merged yet.
First tests using dev-mode and the new participation key rest API's to write more focused tests.
Test Plan
These are tests.