Update participation key goal output #3148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/partkey #3148 +/- ##
===================================================
- Coverage 44.12% 44.07% -0.06%
===================================================
Files 394 394
Lines 87619 87648 +29
===================================================
- Hits 38666 38630 -36
- Misses 42859 42914 +55
- Partials 6094 6104 +10
Continue to review full report at Codecov.
|
winder
force-pushed
the
will/pki-goal-info
branch
from
23b421c to
8c88e2e
Compare
winder
force-pushed
the
will/pki-goal-info
branch
from
7a4999e to
08ccf2a
Compare
tsachiherman
reviewed
Nov 3, 2021
tsachiherman
reviewed
Nov 3, 2021
| fmt.Printf("Key dilution: %d\n", part.Key.VoteKeyDilution) | ||
| fmt.Printf("Selection key: %s\n", base64.StdEncoding.EncodeToString(part.Key.SelectionParticipationKey)) | ||
| fmt.Printf("Voting key: %s\n", base64.StdEncoding.EncodeToString(part.Key.VoteParticipationKey)) | ||
| //fmt.Printf("State proof key: %s\n", base64.StdEncoding.EncodeToString(part.StateProofKey)) |
Contributor
There was a problem hiding this comment.
this is the merkle tree root, right?
Contributor
Author
There was a problem hiding this comment.
For the state proof? I'm not sure, this is kinda stubbed in for state-proof integration. I'll add a TODO comment.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the participation registry for displaying participation key information.
Test Plan